englefly commented on code in PR #19138: URL: https://github.com/apache/doris/pull/19138#discussion_r1178742002
########## fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsCache.java: ########## @@ -146,6 +147,14 @@ public void preHeat() { private void doPreHeat() { List<ResultRow> recentStatsUpdatedCols = null; long retryTimes = 0; + while (!StatisticsUtil.statsTblAvailable()) { Review Comment: if the statsTbl is not available for a long time, does doPreHeat block fe start up? ########## fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsCache.java: ########## @@ -194,6 +203,9 @@ public Optional<ColumnStatistic> join() { return Optional.of(c); } }; + if (c == ColumnStatistic.UNKNOWN) { Review Comment: I think we should not save Unknown stats into statsTable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org