github-actions[bot] commented on code in PR #19126:
URL: https://github.com/apache/doris/pull/19126#discussion_r1178264636
##########
be/src/util/defer_op.h:
##########
@@ -40,4 +40,9 @@ class Defer {
T _closure;
};
+// Nested use Defer, variable name concat line number
+#define DEFER_CONCAT(n, ...) const auto defer##n = Defer([&]() { __VA_ARGS__;
})
Review Comment:
warning: macro is not used [clang-diagnostic-unused-macros]
```cpp
#define DEFER_CONCAT(n, ...) const auto defer##n = Defer([&]() {
__VA_ARGS__; })
^
```
##########
be/src/vec/aggregate_functions/aggregate_function.h:
##########
@@ -47,6 +48,16 @@ using DataTypes = std::vector<DataTypePtr>;
using AggregateDataPtr = char*;
using ConstAggregateDataPtr = const char*;
+#define SAFE_CREATE(create, destroy) \
Review Comment:
warning: macro is not used [clang-diagnostic-unused-macros]
```cpp
#define SAFE_CREATE(create, destroy) \
^
```
##########
be/src/util/defer_op.h:
##########
@@ -40,4 +40,9 @@
T _closure;
};
+// Nested use Defer, variable name concat line number
+#define DEFER_CONCAT(n, ...) const auto defer##n = Defer([&]() { __VA_ARGS__;
})
+#define DEFER_FWD(n, ...) DEFER_CONCAT(n, __VA_ARGS__)
Review Comment:
warning: macro is not used [clang-diagnostic-unused-macros]
```cpp
#define DEFER_FWD(n, ...) DEFER_CONCAT(n, __VA_ARGS__)
^
```
##########
be/src/util/defer_op.h:
##########
@@ -40,4 +40,9 @@
T _closure;
};
+// Nested use Defer, variable name concat line number
+#define DEFER_CONCAT(n, ...) const auto defer##n = Defer([&]() { __VA_ARGS__;
})
+#define DEFER_FWD(n, ...) DEFER_CONCAT(n, __VA_ARGS__)
+#define DEFER(...) DEFER_FWD(__LINE__, __VA_ARGS__)
Review Comment:
warning: macro is not used [clang-diagnostic-unused-macros]
```cpp
#define DEFER(...) DEFER_FWD(__LINE__, __VA_ARGS__)
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
