github-actions[bot] commented on code in PR #19101:
URL: https://github.com/apache/doris/pull/19101#discussion_r1177465945
##########
be/src/util/bitmap_value.h:
##########
@@ -1155,6 +1155,20 @@ class BitmapValue {
DCHECK(res);
}
+ BitmapValue(const BitmapValue& other) = default;
+ BitmapValue(BitmapValue&& other) {
+ std::swap(_type, other._type);
+ std::swap(_sv, other._sv);
+ std::swap(_bitmap, other._bitmap);
+ }
+
+ BitmapValue& operator=(const BitmapValue& other) {
+ _type = other._type;
+ _sv = other._sv;
+ _bitmap = other._bitmap;
+ return *this;
+ }
Review Comment:
warning: use '= default' to define a trivial copy-assignment operator
[modernize-use-equals-default]
```suggestion
BitmapValue& operator=(const BitmapValue& other) = default;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
