github-actions[bot] commented on code in PR #19089:
URL: https://github.com/apache/doris/pull/19089#discussion_r1177321869
##########
be/src/vec/functions/functions_multi_string_search.cpp:
##########
@@ -278,13 +286,18 @@ struct FunctionMultiMatchAnyImpl {
/// zero the result, scan, check, update the offset.
res[i] = 0;
- err = hs_scan(
- regexps->getDB(),
- reinterpret_cast<const char*>(haystack_data.data()) +
prev_haystack_offset,
- static_cast<unsigned>(cur_haystack_length), 0,
smart_scratch.get(), on_match,
- &res[i]);
- if (err != HS_SUCCESS && err != HS_SCAN_TERMINATED)
- return Status::InternalError("failed to scan with vectorscan");
+ if (cur_haystack_length == 0) {
+ null_map[i] = 1;
+ } else {
+ err = hs_scan(
+ regexps->getDB(),
+ reinterpret_cast<const char *>(haystack_data.data()) +
prev_haystack_offset,
+ static_cast<unsigned>(cur_haystack_length), 0,
smart_scratch.get(), on_match,
+ &res[i]);
+ if (err != HS_SUCCESS && err != HS_SCAN_TERMINATED) {
+ return Status::InternalError("failed to scan with
vectorscan");
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if (err != HS_SUCCESS && err != HS_SCAN_TERMINATED) {
return Status::InternalError("failed to scan with
vectorscan");
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
