kaka11chen opened a new pull request, #19043:
URL: https://github.com/apache/doris/pull/19043
# Proposed changes
## Problem summary
In `XXXDecoder::decode_values():`
```
while (size_t run_length =
select_vector.get_next_run<has_filter>(&read_type)) {
...
}
```
It will call `get_next_run()`, need to check `_has_filter` in the loop.
```
size_t get_next_run(DataReadType* data_read_type) {
if (_has_filter) {
} else {
}
}
```
It is unnecessary. So optimize it by adding `has_filter` template param in
`get_next_run()` to decrease `_has_filter` condition checking count in the loop.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you
chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
