yiguolei commented on code in PR #19011:
URL: https://github.com/apache/doris/pull/19011#discussion_r1175213970
##########
be/src/vec/data_types/serde/data_type_number_serde.h:
##########
@@ -210,7 +210,7 @@ void DataTypeNumberSerDe<T>::write_one_cell_to_jsonb(const
IColumn& column,
int row_num) const {
result.writeKey(col_id);
StringRef data_ref = column.get_data_at(row_num);
- if constexpr (std::is_same_v<T, Int8>) {
+ if constexpr (std::is_same_v<T, Int8> || std::is_same_v<T, UInt8>) {
int8_t val = *reinterpret_cast<const int8_t*>(data_ref.data);
Review Comment:
if the value is uint8, but cast it to int8_t at line 214, maybe something
lost?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
