gaodayue edited a comment on issue #3591: URL: https://github.com/apache/incubator-doris/issues/3591#issuecomment-628997925
To be honest I don't know why `ReservationTracker::TransferReservationTo` needs that DCHECK so I'm not sure whether it will cause troubles if removing it. For instance memory tracker, I think either setting limit or not setting limit is fine. Therefore keeping the original design (no limit) looks more safe to me. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
