morningman commented on a change in pull request #3577:
URL: https://github.com/apache/incubator-doris/pull/3577#discussion_r425170848



##########
File path: fe/src/main/java/org/apache/doris/analysis/SlotRef.java
##########
@@ -162,6 +162,12 @@ public String toSqlImpl() {
             return tblName.toSql() + "." + label + sb.toString();
         } else if (label != null) {
             return label + sb.toString();
+        } else if (desc.getSourceExprs() != null) {
+            for (Expr expr : desc.getSourceExprs()) {
+                sb.append(expr.toSql());
+                sb.append(" ");
+            }
+            return sb.toString();

Review comment:
       How about return both `slot id` and `expr`. I'm afraid that `slot id` 
may be used for some tracing debug.
   
   And please fix all related unit tests after you change here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to