yangzhg commented on a change in pull request #3424:
URL: https://github.com/apache/incubator-doris/pull/3424#discussion_r424850252
##########
File path: be/src/olap/rowset/segment_group.cpp
##########
@@ -249,13 +249,13 @@ OLAPStatus
SegmentGroup::add_zone_maps_for_linked_schema_change(
return OLAP_SUCCESS;
}
- // 1. rollup tablet num_key_columns() will less than base tablet
zone_map_fields.size().
+ // 1. rollup tablet get_num_zone_map_columns() will less than base tablet
zone_map_fields.size().
// For LinkedSchemaChange, the rollup tablet keys order is the same as
base tablet
- // 2. adding column to existed table, num_key_columns() will larger than
+ // 2. adding column to existed table, get_num_zone_map_columns() will
larger than
// zone_map_fields.size()
int num_new_keys = 0;
- for (size_t i = 0; i < _schema->num_key_columns(); ++i) {
+ for (size_t i = 0; i < get_num_zone_map_columns(); ++i) {
Review comment:
float and double can generate zone map， bitmap cannot used in duplicate
table, so it OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
