imay commented on a change in pull request #3478:
URL: https://github.com/apache/incubator-doris/pull/3478#discussion_r420612484
##########
File path: be/src/runtime/descriptors.h
##########
@@ -18,12 +18,12 @@
#ifndef DORIS_BE_RUNTIME_DESCRIPTORS_H
#define DORIS_BE_RUNTIME_DESCRIPTORS_H
+#include <ostream>
+#include <unordered_map>
#include <vector>
-#include <tr1/unordered_map>
#include <vector>
-#include <boost/scoped_ptr.hpp>
-#include <ostream>
+#include <boost/scoped_ptr.hpp>
Review comment:
this can be replaced with std::unique_ptr too
##########
File path: be/src/runtime/descriptors.h
##########
@@ -18,12 +18,12 @@
#ifndef DORIS_BE_RUNTIME_DESCRIPTORS_H
#define DORIS_BE_RUNTIME_DESCRIPTORS_H
+#include <ostream>
+#include <unordered_map>
#include <vector>
-#include <tr1/unordered_map>
#include <vector>
Review comment:
there are two vector
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
