Youngwb commented on a change in pull request #3439: URL: https://github.com/apache/incubator-doris/pull/3439#discussion_r417923729
########## File path: gensrc/script/doris_builtins_functions.py ########## @@ -531,6 +531,8 @@ [['rpad'], 'VARCHAR', ['VARCHAR', 'INT', 'VARCHAR'], '_ZN5doris15StringFunctions4rpadEPN9doris_udf' '15FunctionContextERKNS1_9StringValERKNS1_6IntValES6_'], + [['append_trailing_char_if_absent'], 'VARCHAR', ['VARCHAR', 'VARCHAR'], Review comment: may be such like this : ``` MySQL [test]> select append_trailing_char_if_absent('http://google.com','/'); +----------------------------------------------------------+ | append_trailing_char_if_absent('http://google.com', '/') | +----------------------------------------------------------+ | http://google.com/ | +----------------------------------------------------------+ 1 row in set (0.01 sec) MySQL [test]> select append_trailing_char_if_absent('http://google.com/','/'); +-----------------------------------------------------------+ | append_trailing_char_if_absent('http://google.com/', '/') | +-----------------------------------------------------------+ | http://google.com/ | +-----------------------------------------------------------+ ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org