caiconghui edited a comment on issue #3330: Fix rowset_meta race condition for commit_txn in TxnManager URL: https://github.com/apache/incubator-doris/pull/3330#issuecomment-615076301 > > I think TxnManager is better to not know the RowsetMeta concept. > > It's only to know the Transaction concept, so I think the previous name is OK. > > 1. TxnManager **has known** the RowsetMeta concept. > 2. `_txn_mutex` normally means we should get this lock for most of txn operations, but we only get it when `commit_txn` and `publish_txn` > 3. We really use `_txn_mutex` to protect the rowset meta. I think the txn_lock really ensure the commit_txn and publish_txn be complete function which cannot be interrupted by other thread, which not only include rowset_meta modification, function also need to find, insert or find and then delete the txn from txn_map. @kangkaisen @morningman @chaoyli
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
