morningman commented on a change in pull request #3293: [Transaction]Cancel all
txns whose coordinate be is down.
URL: https://github.com/apache/incubator-doris/pull/3293#discussion_r409249854
##########
File path: fe/src/main/java/org/apache/doris/system/HeartbeatMgr.java
##########
@@ -176,6 +176,7 @@ private boolean handleHbResponse(HeartbeatResponse
response, boolean isReplay) {
if (hbResponse.getStatus() != HbStatus.OK) {
// invalid all connections cached in ClientPool
ClientPool.backendPool.clearPool(new
TNetworkAddress(be.getHost(), be.getBePort()));
+
Catalog.getCurrentCatalog().getGlobalTransactionMgr().abortTxnWhenCoordinateBeDown(be.getHost(),
100);
Review comment:
I see.
Another 2 things:
1. Plz rebase the code, the FE meta version 82 has been taken.
2. in `handleHbResponse()` method, if the parameter `isReplay` is true,
means it is a meta log replay thread, so we don't need to process the abort in
a replay thread(This is not like `clearPool()`, which should also be done in
replay thread).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
