morningman commented on a change in pull request #3191: [Optimize][Delete]
Simplify the delete process to make it fast
URL: https://github.com/apache/incubator-doris/pull/3191#discussion_r408858798
##########
File path: fe/src/main/java/org/apache/doris/qe/StmtExecutor.java
##########
@@ -867,6 +867,8 @@ private void handleDdlStmt() {
try {
DdlExecutor.execute(context.getCatalog(), (DdlStmt) parsedStmt,
originStmt);
context.getState().setOk();
+ } catch (QueryStateException e) {
+ context.getState().setOk(0L, 0, e.getMessage());
Review comment:
1. QueryStateException should derived from UserException.
2. Better to just create a `QueryState` inside the QueryStateException, and
here you can just call `context.setState(e.getQueryState());`. If other people
use this exception, he will know how to use it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
