imay commented on a change in pull request #3230: Support load json-data into
Doris by RoutineLoad or StreamLoad
URL: https://github.com/apache/incubator-doris/pull/3230#discussion_r400682774
##########
File path: be/src/exec/broker_reader.h
##########
@@ -52,6 +52,7 @@ class BrokerReader : public FileReader {
// Read
virtual Status read(uint8_t* buf, size_t* buf_len, bool* eof) override;
virtual Status readat(int64_t position, int64_t nbytes, int64_t*
bytes_read, void* out) override;
+ virtual Status read(uint8_t** buf, size_t *length) override;
Review comment:
What's the reason for this new interface? Why not use the already existed
interface?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
