morningman commented on a change in pull request #3219: [Plugin] Making FE audit module pluggable URL: https://github.com/apache/incubator-doris/pull/3219#discussion_r400093100
########## File path: fe/src/main/java/org/apache/doris/qe/AuditEventProcessor.java ########## @@ -0,0 +1,118 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.qe; + +import org.apache.doris.plugin.AuditEvent; +import org.apache.doris.plugin.AuditPlugin; +import org.apache.doris.plugin.Plugin; +import org.apache.doris.plugin.PluginInfo.PluginType; +import org.apache.doris.plugin.PluginMgr; + +import com.google.common.collect.Queues; + +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; + +import java.util.List; +import java.util.concurrent.BlockingQueue; +import java.util.concurrent.TimeUnit; + +/* + * Class for processing all audit events. + * It will receive audit events and handle them to all AUDIT type plugins. + */ +public class AuditEventProcessor { + private static final Logger LOG = LogManager.getLogger(AuditEventProcessor.class); + private static final long UPDATE_PLUGIN_INTERVAL_MS = 60 * 1000; // 1min + + private PluginMgr pluginMgr; + + private List<Plugin> auditPlugins; + private long lastUpdateTime = 0; + + private BlockingQueue<AuditEvent> eventQueue = Queues.newLinkedBlockingDeque(10000); + private Thread workerThread; + + private volatile boolean isStopped = false; + + public AuditEventProcessor(PluginMgr pluginMgr) { + this.pluginMgr = pluginMgr; + } + + public void start() { + workerThread = new Thread(new Worker(), "AuditEventProcessor"); + workerThread.start(); + } + + public void stop() { + isStopped = true; + if (workerThread != null) { + try { + workerThread.join(); + } catch (InterruptedException e) { + // TODO Auto-generated catch block + e.printStackTrace(); Review comment: I will add a LOG.warn here ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
