imay commented on a change in pull request #3172: Change some config
URL: https://github.com/apache/incubator-doris/pull/3172#discussion_r396334687
 
 

 ##########
 File path: conf/fe.conf
 ##########
 @@ -38,7 +38,7 @@ JAVA_OPTS_FOR_JDK_9="-Xmx4096m -XX:SurvivorRatio=8 
-XX:MaxTenuringThreshold=7 -X
 sys_log_level = INFO
 
 # store metadata, create it if it is not exist.
-meta_dir = ${DORIS_HOME}/palo-meta
 
 Review comment:
   Hi @morningman, for this change I don't agree with you.
   
   1. configuration files will not be updated in normal case.
   2. Even if he uses the new configure file, the FE will exit with error 
messages like "There is no meta directory". And this can be fixed by change 
this option to the correct directory.
   
   In my opinion, code must keep compatible with old versions. However, 
configuration default value is unnecessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to