imay commented on a change in pull request #3143: Non blocking OlapTableSink
URL: https://github.com/apache/incubator-doris/pull/3143#discussion_r395410355
##########
File path: be/src/exec/tablet_sink.h
##########
@@ -47,18 +48,101 @@ class ExprContext;
class TExpr;
namespace stream_load {
-
+
class OlapTableSink;
+// The counter of add_batch rpc of a single node
+struct AddBatchCounter {
+ // total execution time of a add_batch rpc
+ int64_t add_batch_execution_time_us = 0;
+ // lock waiting time in a add_batch rpc
+ int64_t add_batch_wait_lock_time_us = 0;
+ // number of add_batch call
+ int64_t add_batch_num = 0;
+ AddBatchCounter& operator+=(const AddBatchCounter& rhs) {
+ add_batch_execution_time_us += rhs.add_batch_execution_time_us;
+ add_batch_wait_lock_time_us += rhs.add_batch_wait_lock_time_us;
+ add_batch_num += rhs.add_batch_num;
+ return *this;
+ }
+ friend AddBatchCounter operator+(const AddBatchCounter& lhs, const
AddBatchCounter& rhs) {
+ AddBatchCounter sum = lhs;
+ sum += rhs;
+ return sum;
+ }
+};
+
+template <typename T>
+class ReusableClosure : public google::protobuf::Closure {
Review comment:
I think should add ref count for this closure. Because this closure is
created by channel, and the RPC call has this pointer. However it is not sure
when the RPC will call this->Run(). If this channel is destructed before the
RPC's callback, it will make invalid memory access. Otherwise it should wait
until the RPC finish, which is unnecessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
