imay commented on a change in pull request #3136: [tablet meta] Do some
refactor on TabletMeta
URL: https://github.com/apache/incubator-doris/pull/3136#discussion_r395405797
##########
File path: be/src/olap/snapshot_manager.cpp
##########
@@ -558,9 +541,9 @@ OLAPStatus
SnapshotManager::_convert_beta_rowsets_to_alpha(const TabletMetaShare
}
if (res == OLAP_SUCCESS && modified) {
if (is_incremental) {
- res = new_tablet_meta->revise_inc_rs_metas(new_rowset_metas);
+ new_tablet_meta->revise_inc_rs_metas(new_rowset_metas);
Review comment:
Seems that it will be better to make argument a rvalue reference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
