morningman commented on a change in pull request #3055: [Spark load] FE creates spark load job and submits spark etl job URL: https://github.com/apache/incubator-doris/pull/3055#discussion_r393741326
########## File path: fe/src/main/java/org/apache/doris/analysis/LoadStmt.java ########## @@ -269,9 +291,17 @@ public Object apply(DataDescription dataDescription) { sb.append("'"); } - if (brokerDesc != null) { - sb.append("\n WITH BROKER '").append(brokerDesc.getName()).append("' ("); - sb.append(new PrintableMap<String, String>(brokerDesc.getProperties(), "=", true, false, true)); + if (dataProcessorDesc != null) { Review comment: I think we can move this block to the `toSql()` method of `dataProcessorDesc ` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org