chaoyli commented on a change in pull request #3110: [UT] Fix some BE unit tests
URL: https://github.com/apache/incubator-doris/pull/3110#discussion_r392551964
##########
File path:
be/test/olap/rowset/segment_v2/bloom_filter_index_reader_writer_test.cpp
##########
@@ -33,14 +33,15 @@
namespace doris {
namespace segment_v2 {
+const std::string dname = "./ut_dir/bloom_filter_index_reader_writer_test";
+
class BloomFilterIndexReaderWriterTest : public testing::Test {
public:
- BloomFilterIndexReaderWriterTest() { }
- virtual ~BloomFilterIndexReaderWriterTest() {
+ virtual void SetUp() {
+ ASSERT_TRUE(boost::filesystem::remove_all(dname));
Review comment:
It's better to use Env to replace boost::filesystem::remove_all
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
