vagetablechicken opened a new issue #3092: MemTracker in broker scan node can't do limit mem URL: https://github.com/apache/incubator-doris/issues/3092 **Describe the bug** https://github.com/apache/incubator-doris/blob/2326b478b62d2482df3472d0a76d30c209a0858f/be/src/exec/broker_scan_node.cpp#L369-L378 We use limit_exceeded() here for mem limit. But the broker scan node's mem_tracker _limit is -1. https://github.com/apache/incubator-doris/blob/4449316d856092fa1df41b55a8f687d35ccf90a7/be/src/runtime/mem_tracker.h#L281-L283 So the limit_exceeded() of mem_tracker(_limit==-1) is always false. Maybe we should use any_limit_exceeded() to check if the ancestors of this mem_tracker limit_exceeded(). The real diagram:      ancestors                  me |...| -> | runtime_state mem_tracker(has limit) | ->| broker_scan_node mem_tracker(-1)|
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
