WingsGo opened a new issue #3053: [Stream Load]Invalid rollback for stream load URL: https://github.com/apache/incubator-doris/issues/3053 **Describe the bug** For #1998 solve the PUBLISH_TIMEOUT will cause BE rollback txn incorrect, but i found there is still some bug. As shown in following log, the txn committed succefully, but FE receive a rollback request ``` 2020-03-07 20:57:31,450 INFO 7812 [GlobalTransactionMgr.commitTransaction():429] transaction:[TransactionState. transaction id: 48471692, label: xxx db id: 10005, coordinator: BE: xxx, transaction status: COMMITTED, error replicas num: 2, replica ids: 64461890,66187307, prepare time: 1583585844933, commit time: 1583585851450, finish time: -1, reason: ] successfully committed 2020-03-07 20:57:36,451 INFO 10956 [FrontendServiceImpl.loadTxnRollback():723] receive txn rollback request. db: xxx, tbl: xxx, txn id: 48471692, reason: transaction commit successfully, BUT data will be visible later, backend: xxx ``` BE's log: ``` W0307 20:55:19.606360 157168 stream_load_executor.cpp:192] commit transaction failed, errmsg=transaction commit successfully, BUT data will be visible laterid=a0481d6290973230-1fe841af6df5088b, job id=-1, txn id=48470900, label=xxx I0307 21:25:42.506554 156973 txn_manager.cpp:496] find expire pending data. tablet_id=64461864 schema_hash=1937251931 tablet_uid=0841acc74eba0dee-576e37036f499486 transaction_id=48470900 exist_sec=1829 ``` I found the reason is that the code in following should also add judge if status is PUBLISH_TIMEOUT, if it is, we shouldn't rollback the txn ``` Status status(result.status); if (!status.ok()) { LOG(WARNING) << "commit transaction failed, errmsg=" << status.get_error_msg() << ctx->brief(); return status; } ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
