[GitHub] [incubator-doris] wutiangan commented on a change in pull request #3034: implements intersect node

[GitBox]

wutiangan commented on a change in pull request #3034: implements intersect node
URL: https://github.com/apache/incubator-doris/pull/3034#discussion_r388748695
 
 

 ##########
 File path: be/src/exec/intersect_node.cpp
 ##########
 @@ -17,36 +17,21 @@
 
 #include "exec/intersect_node.h"
 
+#include "exec/hash_table.hpp"
 #include "exprs/expr.h"
+#include "runtime/row_batch.h"
+#include "runtime/runtime_state.h"
 
 namespace doris {
-// TODO(yangzhengguo) implememt this class
-IntersectNode::IntersectNode(ObjectPool* pool, const TPlanNode& tnode,
-    const DescriptorTbl& descs)
-    : ExecNode(pool, tnode, descs),
-      _tuple_id(tnode.intersect_node.tuple_id),
-      _tuple_desc(nullptr),
-      
_first_materialized_child_idx(tnode.intersect_node.first_materialized_child_idx),
-      _child_idx(0),
-      _child_batch(nullptr),
-      _child_row_idx(0),
-      _child_eos(false),
-      _const_expr_list_idx(0),
-      _to_close_child_idx(-1) {
-}
+IntersectNode::IntersectNode(ObjectPool* pool, const TPlanNode& tnode, const 
DescriptorTbl& descs)
+        : ExecNode(pool, tnode, descs) {}
 
 Status IntersectNode::init(const TPlanNode& tnode, RuntimeState* state) {
-    // RETURN_IF_ERROR(ExecNode::init(tnode, state));
     RETURN_IF_ERROR(ExecNode::init(tnode, state));
     DCHECK(tnode.__isset.intersect_node);
     DCHECK_EQ(_conjunct_ctxs.size(), 0);
-    // Create const_expr_ctx_lists_ from thrift exprs.
-    auto& const_texpr_lists = tnode.intersect_node.const_expr_lists;
-    for (auto& texprs : const_texpr_lists) {
-        std::vector<ExprContext*> ctxs;
-        RETURN_IF_ERROR(Expr::create_expr_trees(_pool, texprs, &ctxs));
-        _const_expr_lists.push_back(ctxs);
-    }
+    DCHECK_GE(_children.size(), 2);
+    DCHECK_EQ(tnode.intersect_node.const_expr_lists.size(), 0);
 
 Review comment:
   const_expr_list not use? why not delete it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org