WingsGo commented on a change in pull request #2980: [Conf]Make default_storage_medium configurable URL: https://github.com/apache/incubator-doris/pull/2980#discussion_r388068022
########## File path: fe/src/main/java/org/apache/doris/catalog/PartitionInfo.java ########## @@ -127,7 +127,7 @@ public void write(DataOutput out) throws IOException { out.writeInt(idToDataProperty.size()); for (Map.Entry<Long, DataProperty> entry : idToDataProperty.entrySet()) { out.writeLong(entry.getKey()); - if (entry.getValue() == DataProperty.DEFAULT_HDD_DATA_PROPERTY) { + if (entry.getValue() == DataProperty.DEFAULT_DATA_PROPERTY) { Review comment: If we need to compatible with old version, I can chnage it to `entry.getValue() == new DataProperty(TStorageMedium.HDD)` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org