morningman commented on a change in pull request #3036: Support different keys
type between mv and base table
URL: https://github.com/apache/incubator-doris/pull/3036#discussion_r387687421
##########
File path:
fe/src/main/java/org/apache/doris/analysis/CreateMaterializedViewStmt.java
##########
@@ -188,6 +189,7 @@ else if (functionChild0 instanceof CastExpr
+ "Error function: " +
functionCallExpr.toSqlImpl());
}
meetAggregate = true;
+ mvKeysType = KeysType.AGG_KEYS;
Review comment:
Why setting `mvKeysType` again since you already set it before?
Do we allowed user create mv like `select k1, k2, sum(v1)` without `group
by` clause?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
