imay commented on a change in pull request #2979: Incomplete support Array type
(#2871)
URL: https://github.com/apache/incubator-doris/pull/2979#discussion_r386077191
##########
File path: be/src/common/object_pool.h
##########
@@ -47,6 +47,15 @@ class ObjectPool {
_objects.push_back(obj);
return t;
}
+
+ template <class T>
+ T* add_array(T* t) {
+ ArrayElement<T>* obj = new ArrayElement<T>(t);
+ DCHECK(obj != NULL);
+ boost::lock_guard<SpinLock> l(_lock);
Review comment:
use std::lock_guard instead
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
