imay commented on a change in pull request #2991: Output null for hll and
bitmap column when select *
URL: https://github.com/apache/incubator-doris/pull/2991#discussion_r384316760
##########
File path: fe/src/main/java/org/apache/doris/analysis/SelectStmt.java
##########
@@ -786,15 +785,14 @@ private void expandStar(Analyzer analyzer, TableName
tblName) throws AnalysisExc
* Expand "*" for a particular tuple descriptor by appending
* refs for each column to selectListExprs.
*/
- private void expandStar(TableName tblName, TupleDescriptor desc) throws
AnalysisException {
+ private void expandStar(TableName tblName, TupleDescriptor desc) {
for (Column col : desc.getTable().getBaseSchema()) {
- if (col.getDataType() == PrimitiveType.HLL && !fromInsert) {
- throw new AnalysisException(Type.OnlyMetricTypeErrorMsg);
- }
- if (col.getAggregationType() == AggregateType.BITMAP_UNION &&
!fromInsert) {
- throw new AnalysisException(Type.OnlyMetricTypeErrorMsg);
+ PrimitiveType type = col.getDataType();
Review comment:
> 1. there is a performance issue, we still need to scan the HLL or Bitmap
column
I think performance may not be very important in this case
> 2. we need to support return binary content for HLL or Bitmap, so we
shouldn't send null directly in ResultSink, we must pass a config from FE to BE.
Maybe we can support this feature later, and wait until the situation is
really needed? Or the user can get the encoded readable content through the hex
or base64 function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
