imay commented on a change in pull request #2953: [segment_v2] Switch to
Unified and Extensible Page Format
URL: https://github.com/apache/incubator-doris/pull/2953#discussion_r382045727
##########
File path: gensrc/proto/segment_v2.proto
##########
@@ -205,22 +191,52 @@ message IndexedColumnMetaPB {
optional uint64 size = 7;
}
-message BitmapIndexColumnPB {
+// -------------------------------------------------------------
+// Column Index Metadata
+// -------------------------------------------------------------
+
+enum ColumnIndexTypePB {
+ ORDINAL_INDEX = 0;
+ ZONE_MAP_INDEX = 1;
+ BITMAP_INDEX = 2;
+ BLOOM_FILTER_INDEX = 3;
+}
+
+message ColumnIndexMetaPB {
+ optional ColumnIndexTypePB type = 1;
+ optional OrdinalIndexPB ordinal_index = 7;
Review comment:
Why not use 2,3,4,5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
