trueeyu opened a new pull request #2961: [ut] fix the  test case of 
SegmentReaderWriterTest::TestBitmapPredicate
URL: https://github.com/apache/incubator-doris/pull/2961
 
 
   function create_int_key() will create a TableColumn instance with data 
memger: _aggregation=(random value)
   
   if _aggregation==OLAP_FIELD_AGGREGATION_REPLACE SegmentWriter::init() will 
set opts.need_bitmap_index = false;
   
   so the test case TEST_F(SegmentReaderWriterTest, TestBitmapPredicate)  of 
olap/rowset/segment_v2/segment_test.cpp will exec failed if the_aggregation of 
TableColumn == OLAP_FIELD_AGGREGATION_REPLACE.
   
   ```
   TEST_F(SegmentReaderWriterTest, TestBitmapPredicate) {
       TabletSchema tablet_schema = create_schemate({
           create_int_key(1, true, false, true),
           create_int_key(2, true, false, true),
           create_int_value(3),
           create_int_value(4)});
          ...
         ASSERT_TRUE(segment->footer().columns(0).has_bitmap_index());
         ...
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to