morningman commented on a change in pull request #2956: Add multi-thread ver olaptablesink for LOAD URL: https://github.com/apache/incubator-doris/pull/2956#discussion_r382034126
########## File path: fe/src/main/java/org/apache/doris/planner/OlapTableSink.java ########## @@ -88,12 +92,29 @@ public OlapTableSink(OlapTable dstTable, TupleDescriptor tupleDescriptor, List<L } } + public OlapTableSink(OlapTable dstTable, TupleDescriptor tupleDescriptor, List<Long> partitionIds, int bufferNum, + long memLimitPerBuf, long sizeLimitPerBuf) { + this(dstTable, tupleDescriptor, partitionIds); + this.bufferNum = bufferNum; + this.memLimitPerBuf = memLimitPerBuf; + this.sizeLimitPerBuf = sizeLimitPerBuf; + } + public void init(TUniqueId loadId, long txnId, long dbId, long loadChannelTimeoutS) throws AnalysisException { TOlapTableSink tSink = new TOlapTableSink(); tSink.setLoad_id(loadId); tSink.setTxn_id(txnId); tSink.setDb_id(dbId); tSink.setLoad_channel_timeout_s(loadChannelTimeoutS); + + if (bufferNum > 0) { + tSink.setBuffer_num(bufferNum); + if (memLimitPerBuf > 0) Review comment: warp with `{}`, even if there is only one line after `if` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org