imay commented on a change in pull request #2890: Add
disable_storage_page_cache config
URL: https://github.com/apache/incubator-doris/pull/2890#discussion_r378319862
##########
File path: be/src/olap/rowset/segment_v2/column_reader.cpp
##########
@@ -97,7 +97,7 @@ Status ColumnReader::read_page(RandomAccessFile* file, const
PagePointer& pp,
auto cache = StoragePageCache::instance();
PageCacheHandle cache_handle;
StoragePageCache::CacheKey cache_key(file->file_name(), pp.offset);
- if (cache->lookup(cache_key, &cache_handle)) {
+ if (!config::disable_storage_page_cache && cache->lookup(cache_key,
&cache_handle)) {
Review comment:
It is better to use an argument for this function.
Besides the configuration, some operation don't need cache either, such as
compaction.
So the good way is that let the caller judge whether the cache is used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
