morningman commented on a change in pull request #2877: [FIX] fix a bug when
using grouping set without all column in a grouping set item
URL: https://github.com/apache/incubator-doris/pull/2877#discussion_r377632292
##########
File path: fe/src/main/java/org/apache/doris/analysis/GroupByClause.java
##########
@@ -202,12 +202,7 @@ public void analyze(Analyzer analyzer) throws
AnalysisException {
}
public boolean isGroupByExtension() {
- if (groupingType == GroupingType.GROUP_BY ||
- groupingType == GroupingType.GROUPING_SETS && (groupingSetList
== null || groupingSetList.size() < 2)) {
- return false;
- } else {
- return true;
- }
+ return groupingType != GroupingType.GROUP_BY;
Review comment:
Plz add comment to this function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
