morningman commented on issue #2663: [Proposal] Support partition overwrite operation URL: https://github.com/apache/incubator-doris/issues/2663#issuecomment-584175459 > > > In the statement the replaced partition is already specified. > > > > > > No, I mean we have to specify the name of corresponding formal partition in `CREATE TEMP PARTITION` stmt. Otherwise we can control the range of a temp partition user created. > > I don't quite understand why you should indicate the name of the associated partition when creating the partition? > > > And I think this is OK, just leave it to user how to use it. And in `REPLACE` operation, I will only check after replacing, the new ranges are not conflict. > > I want to emphasize that it is not enough to just check for conflicts. You need to check if the two partitions replaced before and after are exactly enough to cover. The conflict just says that the partitions overlap, and there is another case where there are holes between the partitions I mean, for example, the origin partition(p1, p2) ranges are: [0, 10) [10, 20) And user create 2 temp partitions (tp1, tp2) with range: [10, 11) and [15, 18) And user replace the (p1, p2) with (tp1, tp2), should we allow this operation? Two options. First, we check strictly. The range must be covered and equal. But if user really want to new range of tp1 and tp2? So the second option is, we only check for conflicts and not for coverage.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
