wangbo commented on a change in pull request #2781: Batch Operate Rollup table
in Doris #2671
URL: https://github.com/apache/incubator-doris/pull/2781#discussion_r376759532
##########
File path: fe/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
##########
@@ -830,8 +1008,14 @@ public void cancel(CancelStmt stmt) throws DdlException {
}
// find from new alter jobs first
- rollupJobV2 = getUnfinishedAlterJobV2(olapTable.getId());
- if (rollupJobV2 == null) {
+ if (cancelAlterTableStmt.getAlterJobIdList() != null) {
+ for (Long jobId : cancelAlterTableStmt.getAlterJobIdList()) {
+ rollupJobV2List.add(getUnfinishedAlterJobV2ByJobId(jobId));
Review comment:
In current implementation,all rollup job is independent,`partial success`
just affect user experience,atomic batch operation is not necessary.
I prefer execute batch operation in async way, user submit a stmt, and use
another stmt to check result.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
