lingbin commented on a change in pull request #2858: fix core when using
grouping sets in large data
URL: https://github.com/apache/incubator-doris/pull/2858#discussion_r376358569
##########
File path: be/src/exec/repeat_node.cpp
##########
@@ -100,10 +93,18 @@ Status RepeatNode::get_repeated_batch(
continue;
}
- char* new_tuple = reinterpret_cast<char*>(dst_tuples[j]);
- new_tuple += (*dst_it)->byte_size();
- dst_tuples[j] = reinterpret_cast<Tuple*>(new_tuple);
-
+ if (dst_tuples[j] == nullptr) {
+ int size = row_batch->capacity() * (*dst_it)->byte_size();
Review comment:
is it a typo? should we use row_batch's capacity to calculate one tuple's
memory size?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
