lingbin opened a new pull request #2831: Refactor `AgentServer` to make it less error-prone and more readable URL: https://github.com/apache/incubator-doris/pull/2831 In `AgentServer`, each task type needs to be processed separately, which leads to very long code, hard to read, and not easy to detect errors (for example, some task type processing may be missed, corresponding relationship may be error) Fortunately, the code for each task_type is very similar, so this is a good case to use `MACRO`, which can greatly reduce the repeated code and solve above problems. This patch also fix two small bugs: 1. The `_topic_subscriber` member has not been released in dtor 2. in `submit_tasks()`, the `status_code` is not reset before each task is processed, resulting in wrong judgment. No functional changes in this patch.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
