morningman commented on a change in pull request #2804: [JDK] Support OpenJDK
URL: https://github.com/apache/incubator-doris/pull/2804#discussion_r372163657
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/PaloFe.java
 ##########
 @@ -53,6 +54,10 @@
 
     // entrance for palo frontend
     public static void main(String[] args) {
+        if (!checkJavaVersion()) {
 
 Review comment:
   `checkJavaVersion()` does not, and should not depend on any configurations 
of the program. It only depends on the java runtime environment, which should 
already be initialized
   when we get here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to