gaodayue commented on a change in pull request #2782: Add file cache for v2
URL: https://github.com/apache/incubator-doris/pull/2782#discussion_r367822820
##########
File path: be/src/env/env_posix.cpp
##########
@@ -498,6 +499,11 @@ class PosixEnv : public Env {
return Status::OK();
}
+ Status new_random_access_file(const std::string& fname,
Review comment:
Without documentation or a clear name, user will consider the following
```
std::shared_ptr<RandomAccessFile> f;
env->new_random_access_file(filename, &f);
```
to be the same as
```
std::unique_ptr<RandomAccessFile> f1;
env->new_random_access_file(filename, &f1);
// upgrade to shared_ptr
std::shared_ptr<RandomAccessFile> f = std::move(f1);
```
which is not true.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
