kangkaisen commented on a change in pull request #2781: Batch Operate Rollup table in Doris #2671 URL: https://github.com/apache/incubator-doris/pull/2781#discussion_r367953015
########## File path: fe/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java ########## @@ -85,6 +90,71 @@ public MaterializedViewHandler() { super("materialized view"); } + + // for batch submit rollup job, tableId -> jobId + // keep table's not final state job size. The job size determine's table's state, = 0 means table is normal,otherwrise is rollup + private Map<Long, Set<Long>> tableNotFinalStateJobMap = new ConcurrentHashMap<>(); + // keep table's running job,used for concurrency limit + private Map<Long, Set<Long>> tableRunningJobMap = new ConcurrentHashMap<>(); + // make sure that job's dependency just init once + private volatile boolean hasBuildJobDependency = false; Review comment: For simple. I think we needn't introduce the `Dependency` concept. We could check the `alter statement` and require the from index must exist firstly, and then, we needn't consider the rollup job dependency. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org