kangkaisen commented on a change in pull request #2731: Add bitamp_to_string
function
URL: https://github.com/apache/incubator-doris/pull/2731#discussion_r365632305
##########
File path: be/test/util/bitmap_test.cpp
##########
@@ -267,6 +267,30 @@ TEST_F(BitMapTest, roaring_bitmap_serde) {
ASSERT_EQ(3, bitmap_serde.cardinality());
}
+TEST_F(BitMapTest, bitmap_to_string) {
+ RoaringBitmap empty;
+ ASSERT_STREQ("", empty.to_string().c_str());
+ empty.update(1);
+ ASSERT_STREQ("1", empty.to_string().c_str());
+ empty.update(2);
+ ASSERT_STREQ("1,2", empty.to_string().c_str());
+}
+
+TEST_F(BitMapTest, bitmap_from_vector) {
Review comment:
Would better add a invalid string format test case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
