lingbin commented on a change in pull request #2704: Remove resource_info
related members from TaskWorkerPool
URL: https://github.com/apache/incubator-doris/pull/2704#discussion_r365508499
##########
File path: be/src/agent/task_worker_pool.cpp
##########
@@ -310,20 +260,20 @@ void
TaskWorkerPool::_spawn_callback_worker_thread(CALLBACK_FUNCTION callback_fu
}
void TaskWorkerPool::_finish_task(const TFinishTaskRequest&
finish_task_request) {
- // Return result to fe
+ // Return result to FE
TMasterResult result;
- int32_t try_time = 0;
+ uint32_t try_time = 0;
while (try_time < TASK_FINISH_MAX_RETRY) {
DorisMetrics::finish_task_requests_total.increment(1);
AgentStatus client_status =
_master_client->finish_task(finish_task_request, &result);
if (client_status == DORIS_SUCCESS) {
- LOG(INFO) << "finish task success. result:" <<
result.status.status_code;
+ LOG(INFO) << "finish task success.";
break;
} else {
DorisMetrics::finish_task_requests_failed.increment(1);
- OLAP_LOG_WARNING("finish task failed.result: %d",
result.status.status_code);
+ OLAP_LOG_WARNING("finish task failed. result: %d",
result.status.status_code);
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
