imay commented on a change in pull request #2674: ADD BE UDF bitmap_and and
bitmap_or
URL: https://github.com/apache/incubator-doris/pull/2674#discussion_r363589696
##########
File path: be/src/exprs/bitmap_function.cpp
##########
@@ -388,6 +388,54 @@ BigIntVal
BitmapFunctions::bitmap_intersect_finalize(FunctionContext* ctx, const
return result;
}
+StringVal BitmapFunctions::bitmap_or(FunctionContext* ctx, const StringVal&
src, const StringVal& dst){
+ RoaringBitmap bitmap;
Review comment:
To make code clear, you can do as follow
```
if (lhs.is_null || rhs.is_null) {
return StringVal::null();
}
```
And then there is no need to check src.is_null again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
