This is an automated email from the ASF dual-hosted git repository.
zhaoc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 40c8bdd Decrease transaction_clean_interval_second config (#2673)
40c8bdd is described below
commit 40c8bddd24b77522f89e1de93f7ec2ea82a7ff31
Author: kangkaisen <kangkai...@apache.org>
AuthorDate: Mon Jan 6 20:16:37 2020 +0800
Decrease transaction_clean_interval_second config (#2673)
---
fe/src/main/java/org/apache/doris/common/Config.java | 3 ++-
.../main/java/org/apache/doris/transaction/GlobalTransactionMgr.java | 2 ++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/fe/src/main/java/org/apache/doris/common/Config.java
b/fe/src/main/java/org/apache/doris/common/Config.java
index 48cfee1..abed9ec 100644
--- a/fe/src/main/java/org/apache/doris/common/Config.java
+++ b/fe/src/main/java/org/apache/doris/common/Config.java
@@ -119,8 +119,9 @@ public class Config extends ConfigBase {
@ConfField public static int label_clean_interval_second = 4 * 3600; // 4
hours
/*
* the transaction will be cleaned after transaction_clean_interval_second
seconds if the transaction is visible or aborted
+ * we should make this interval as short as possible and each clean cycle
as soon as possible
*/
- @ConfField public static int transaction_clean_interval_second = 300; // 5
min
+ @ConfField public static int transaction_clean_interval_second = 30;
// Configurations for meta data durability
/*
diff --git
a/fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java
b/fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java
index f1b41b3..0851d41 100644
--- a/fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java
+++ b/fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java
@@ -821,6 +821,8 @@ public class GlobalTransactionMgr implements Writable {
* The txn cleaner will run at a fixed interval and try to delete expired
and timeout txns:
* expired: txn is in VISIBLE or ABORTED, and is expired.
* timeout: txn is in PREPARE, but timeout
+ * Todo(kks): currently remove transaction performance is bad, if we want
to support
+ * super-high concurrent transaction, we should improve this method
*/
public void removeExpiredAndTimeoutTxns() {
long currentMillis = System.currentTimeMillis();
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
