imay commented on a change in pull request #2644: fix estimate_segment_size problem #2643 URL: https://github.com/apache/incubator-doris/pull/2644#discussion_r362688059
########## File path: be/src/olap/rowset/segment_v2/column_writer.h ########## @@ -168,6 +171,7 @@ class ColumnWriter { PagePointer _ordinal_index_pp; PagePointer _zone_map_pp; PagePointer _dict_page_pp; + uint64_t _data_size; Review comment: give some comment for this member ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org