imay commented on a change in pull request #2531: Spark return error to users
when spark on doris query failed
URL: https://github.com/apache/incubator-doris/pull/2531#discussion_r361677653
##########
File path: be/src/runtime/result_queue_mgr.cpp
##########
@@ -78,10 +83,36 @@ Status ResultQueueMgr::cancel(const TUniqueId&
fragment_instance_id) {
std::lock_guard<std::mutex> l(_lock);
auto iter = _fragment_queue_map.find(fragment_instance_id);
if (iter != _fragment_queue_map.end()) {
+ // first remove RecordBatch from queue
+ // avoid MemoryScratchSink block on send or close operation
+ iter->second->clear();
// remove this queue from map
_fragment_queue_map.erase(fragment_instance_id);
}
return Status::OK();
}
+Status ResultQueueMgr::queue_status(const TUniqueId& fragment_instance_id) {
Review comment:
seems that no one use this function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
