morningman commented on a change in pull request #2477: [PROPOSAL]Support
Dynamic Partition(adapt GSON serialize)
URL: https://github.com/apache/incubator-doris/pull/2477#discussion_r361674500
##########
File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java
##########
@@ -5035,6 +5074,35 @@ public void replayRenameColumn(TableInfo tableInfo)
throws DdlException {
throw new DdlException("not implmented");
}
+ public void modifyTableDynamicPartition(Database db, OlapTable table,
Map<String, String> properties) throws DdlException {
+ Map<String, String> analyzedDynamicPartition =
DynamicPartitionUtil.analyzeDynamicPartition(db, table, properties);
+ TableProperty tableProperty = table.getTableProperty();
+ if (tableProperty != null) {
Review comment:
I think even if table property is null, we can still modify the dynamic
partition property. Just like adding dynamic partition property for a table at
runtime.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
