imay commented on a change in pull request #2573: implements create drop show
index syntax for bitmap index [#2487]
URL: https://github.com/apache/incubator-doris/pull/2573#discussion_r361552826
##########
File path: be/src/olap/tablet_schema.h
##########
@@ -40,6 +40,7 @@ class TabletColumn {
inline bool is_key() const { return _is_key; }
inline bool is_nullable() const { return _is_nullable; }
inline bool is_bf_column() const { return _is_bf_column; }
+ inline bool is_bitmap_column() const {return _is_bitmap_column; }
Review comment:
Prefer has_bitmap_index(). Becuase Doris has a column type which is bitmap,
`is_bitmap_column` is confusing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
