imay commented on a change in pull request #2554: Support load orc format in Apache Doris URL: https://github.com/apache/incubator-doris/pull/2554#discussion_r361156792
########## File path: be/src/exec/orc_scanner.cpp ########## @@ -0,0 +1,261 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "exec/orc_scanner.h" + +#include "runtime/descriptors.h" +#include "runtime/exec_env.h" +#include "runtime/mem_tracker.h" +#include "runtime/raw_value.h" +#include "runtime/tuple.h" +#include "exprs/expr.h" +#include "exec/text_converter.h" +#include "exec/text_converter.hpp" +#include "exec/local_file_reader.h" +#include "exec/broker_reader.h" + +namespace doris { + +ORCScanner::ORCScanner(RuntimeState* state, + RuntimeProfile* profile, + const TBrokerScanRangeParams& params, + const std::vector<TBrokerRangeDesc>& ranges, + const std::vector<TNetworkAddress>& broker_addresses, + ScannerCounter* counter) : BaseScanner(state, profile, params, counter), + _ranges(ranges), + _broker_addresses(broker_addresses), + // _splittable(params.splittable), + _next_range(0), + _cur_file_eof(true), + _scanner_eof(false) {} + +ORCScanner::~ORCScanner() { + close(); +} + +Status ORCScanner::open() { + return BaseScanner::open(); +} + +Status ORCScanner::get_next(Tuple* tuple, MemPool* tuple_pool, bool* eof) { + try { + SCOPED_TIMER(_read_timer); + // Get one line + while (!_scanner_eof) { + if (_cur_file_eof) { + RETURN_IF_ERROR(open_next_reader()); + if (_scanner_eof) { + *eof = true; + return Status::OK(); + } else { + _cur_file_eof = false; + } + } + if (_current_line_of_group >= _rows_of_group) { // read next stripe + if (_current_group >= _total_groups) { + _cur_file_eof = true; + continue; + } + _rows_of_group = _reader->getStripe(_current_group)->getNumberOfRows(); + std::cout << "rows of group "<< _rows_of_group << std::endl; + _batch = _row_reader->createRowBatch(_rows_of_group); + _row_reader->next(*_batch.get()); + + _current_line_of_group = 0; + ++_current_group; + } + + std::vector<orc::ColumnVectorBatch *> _batch_vec = ((orc::StructVectorBatch *) _batch.get())->fields; + for (int column_ipos = 0; column_ipos < _num_of_columns_from_file; ++column_ipos) { + auto slot_desc = _src_slot_descs[column_ipos]; + orc::ColumnVectorBatch *cvb = _batch_vec[_column_name_map_orc_index.find( + slot_desc->col_name())->second]; + + if (cvb->hasNulls && !cvb->notNull[_current_line_of_group]) { + if (!slot_desc->is_nullable()) { + std::stringstream str_error; + str_error << "The field name(" << slot_desc->col_name() + << ") is not allowed null, but ORC field is NULL."; + LOG(WARNING) << str_error.str(); + return Status::RuntimeError(str_error.str()); + } + _src_tuple->set_null(slot_desc->null_indicator_offset()); + } else { + int32_t wbytes = 0; + uint8_t tmp_buf[128] = {0}; + _src_tuple->set_not_null(slot_desc->null_indicator_offset()); + void *slot = _src_tuple->get_slot(slot_desc->tuple_offset()); + StringValue *str_slot = reinterpret_cast<StringValue *>(slot); + + switch (_reader->getType().getSubtype(column_ipos)->getKind()) { + case orc::BOOLEAN: { + int64_t value = ((orc::LongVectorBatch *) cvb)->data[_current_line_of_group]; + if (value == 0) { + str_slot->ptr = reinterpret_cast<char *>(tuple_pool->allocate(5)); + memcpy(str_slot->ptr, "false", 5); + str_slot->len = 5; + } else { + str_slot->ptr = reinterpret_cast<char *>(tuple_pool->allocate(4)); + memcpy(str_slot->ptr, "true", 4); + str_slot->len = 4; + } + break; + } + case orc::INT: + case orc::SHORT: + case orc::LONG: + case orc::DATE: { + int64_t value = ((orc::LongVectorBatch *) cvb)->data[_current_line_of_group]; + std::cout << "value : " << value << std::endl; Review comment: remove debug ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
