kangpinghuang commented on a change in pull request #2294: Add convert tablet 
rowset type
URL: https://github.com/apache/incubator-doris/pull/2294#discussion_r358687297
 
 

 ##########
 File path: be/src/olap/schema_change.cpp
 ##########
 @@ -1661,6 +1677,11 @@ OLAPStatus 
SchemaChangeHandler::_convert_historical_rowsets(const SchemaChangePa
         goto PROCESS_ALTER_EXIT;
     }
 
+    if (sc_params.new_tablet->tablet_meta()->preferred_rowset_type() == 
BETA_ROWSET) {
+        // if the tablet meta has preferred_rowset_type field set to 
BETA_ROWST, just use directly type
+        sc_directly = true;
 
 Review comment:
   I remove this logic to parse_request, and it will avoid the problem you 
mentioned.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to